Revert "kvserver: separate repl q decision from action" #91043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d9448f4. The commit was causing `TestPartialZip` to reliably fail. The cause of the failure has not been investigated, but this revert allows us to do so async without blocking master.
|
This change is |
AlexTalks
approved these changes
Nov 1, 2022
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @kvoli)
|
There's a circular dependency between this PR and #91031. We're going to have to hope that they end up in the same bors batch 🤞 TFTR! bors r+ |
|
|
|
Build failed (retrying...): |
|
bors r- Flake on |
|
Canceled. |
|
bors r+ |
|
Build succeeded: |
#91044 take two |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d9448f4.
The commit was causing
TestPartialZipto reliably fail. The cause of the failure has not been investigated, but this revert allows us to do so async without blocking master.Epic: None