Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: let extendedEvalContext.QueueJob() use txn from planner #91186

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

ZhouXing19
Copy link
Collaborator

@ZhouXing19 ZhouXing19 commented Nov 3, 2022

This commit is part of the effort to reduce usages of eval.Context.txn.

We now let *kv.Txn be passed in as a parameter to extendedEvalContext.QueueJob().

Informs: #91004

Release note: None

This commit is part of the effort to reduce usages of `eval.Context.txn`.

We now let `*kv.Txn` be passed in as a parameter to `extendedEvalContext.QueueJob()`.

Release note: None
@ZhouXing19 ZhouXing19 requested a review from a team as a code owner November 3, 2022 13:12
@ZhouXing19 ZhouXing19 requested a review from a team November 3, 2022 13:12
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @ZhouXing19)

@ZhouXing19
Copy link
Collaborator Author

TFTR!
bors r=ajwerner

@craig
Copy link
Contributor

craig bot commented Nov 3, 2022

Build failed (retrying...):

@ZhouXing19
Copy link
Collaborator Author

bors r+

@ZhouXing19
Copy link
Collaborator Author

bors r-

@ZhouXing19
Copy link
Collaborator Author

bors r+

@craig
Copy link
Contributor

craig bot commented Nov 7, 2022

Build succeeded:

@craig craig bot merged commit 11618b1 into cockroachdb:master Nov 7, 2022
@blathers-crl
Copy link

blathers-crl bot commented Nov 7, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from d954eac to blathers/backport-release-22.2-91186: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants