Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: sql: let extendedEvalContext.QueueJob() use txn from planner #91402

Conversation

ZhouXing19
Copy link
Collaborator

@ZhouXing19 ZhouXing19 commented Nov 7, 2022

Backport 1/1 commits from #91186.

/cc https://github.com/orgs/cockroachdb/teams/release

This commit is part of the effort to reduce usages of eval.Context.txn.

We now let *kv.Txn be passed in as a parameter to extendedEvalContext.QueueJob().

Informs: #91004

Release note: None

Release justification: Non-production code changes.

…planner

This commit is part of the effort to reduce usages of `eval.Context.txn`.

We now let `*kv.Txn` be passed in as a parameter to `extendedEvalContext.QueueJob()`.

Release note: None
@ZhouXing19 ZhouXing19 requested a review from a team as a code owner November 7, 2022 15:13
@ZhouXing19 ZhouXing19 requested a review from a team November 7, 2022 15:13
@blathers-crl
Copy link

blathers-crl bot commented Nov 7, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@stevendanna
Copy link
Collaborator

@ZhouXing19 I wonder if we can close this now? Would we do an extraordinary release for it?

@ZhouXing19 ZhouXing19 closed this Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants