storage: Fix CheckSSTConflicts stats calculations #98426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
I got a couple hundred runs of the updated KVNemesis running successfully after this change. I'll do a longer stress run on Monday to see if something is still missing. |
erikgrinaker
approved these changes
Mar 11, 2023
Previously we were missing some cases of range key overlaps with other range keys, or were too eagerly stepping over engine keys that did not conflict with sstable keys, resulting in incorrect stats. This change adds more targeted test cases to TestEvalAddSSTable to test for those previously-unaccounted cases, and fixes them in CheckSSTConflicts. Informs cockroachdb#94140 and cockroachdb#98408. Fixes cockroachdb#94141. Epic: none Release note: None
itsbilal
force-pushed
the
checksstconflicts-stats-fixes
branch
from
8e4775b
to
7d00079
Compare
|
Had to do two more fixes before kvnemesis would go into the thousands of runs, and now it seems to chug along well. 🤞 |
|
bors r=erikgrinaker |
|
Build succeeded: |
This was referenced Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were missing some cases of range key overlaps with other range keys, or were too eagerly stepping over engine keys that did not conflict with sstable keys, resulting in incorrect stats. This change adds more targeted test cases to TestEvalAddSSTable to test for those previously-unaccounted cases, and fixes them in CheckSSTConflicts.
Informs #94140 and #98408.
Fixes #94141.
Epic: none
Release note: None