Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: Fix CheckSSTConflicts stats calculations #98426

Merged
merged 1 commit into from
Mar 12, 2023

Commits on Mar 12, 2023

  1. storage: Fix CheckSSTConflicts stats calculations

    Previously we were missing some cases of range key
    overlaps with other range keys, or were too eagerly
    stepping over engine keys that did not conflict with
    sstable keys, resulting in incorrect stats. This change
    adds more targeted test cases to TestEvalAddSSTable to
    test for those previously-unaccounted cases, and fixes them
    in CheckSSTConflicts.
    
    Informs cockroachdb#94140 and cockroachdb#98408.
    Fixes cockroachdb#94141.
    
    Epic: none
    
    Release note: None
    itsbilal committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    7d00079 View commit details
    Browse the repository at this point in the history