Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: execinfra: correctly propagate processorID for LocalProcessors #98702

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

yuzefovich
Copy link
Member

Backport 1/1 commits from #98654.

/cc @cockroachdb/release


Previously, this was incorrectly hard-coded as zero. The impact of this seems minor (I believe this would only make it so that we could incorrectly attribute ComponentStats object of planNodeToRowSource to the wrong processor), but I think it still deserves to be backported.

Epic: None

Release note: None

Release justification: low risk bug fix.

Previously, this was incorrectly hard-coded as zero. The impact of this
seems minor (I believe this would only make it so that we could
incorrectly attribute `ComponentStats` object of `planNodeToRowSource`
to the wrong processor), but I think it still deserves to be backported.

Release note: None
@yuzefovich yuzefovich requested review from michae2 and a team March 15, 2023 18:47
@blathers-crl
Copy link

blathers-crl bot commented Mar 15, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl
Copy link

blathers-crl bot commented Mar 15, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)

@yuzefovich yuzefovich merged commit 1f9e37b into cockroachdb:release-22.2 Mar 15, 2023
@yuzefovich yuzefovich deleted the backport22.2-98654 branch March 15, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants