roachtest: use local SSDs for disk-stall failover tests #99963
Conversation
|
This change is |
|
I took this for a spin. Each of the three variants passed: |
nicktrav
requested review from
herkolategan and
smg260
and removed request for
a team
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @herkolategan, @nicktrav, and @smg260)
-- commits line 4 at r1:
nit: to not use?
-- commits line 6 at r1:
nit: something missing/odd in "the used for ..."
pkg/cmd/roachtest/tests/disk_stall.go line 51 at r1 (raw file):
s := r.MakeClusterSpec(4, spec.ReuseNone()) // Use local SSDs in an attempt to work around flakes encountered when using // SSDs. See #97968.
Confused here too. #99747 says switch to PD.
pkg/cmd/roachtest/tests/failover.go line 52 at r1 (raw file):
if failureMode == failureModeDiskStall { // Use local SSDs in an attempt to work around flakes encountered when // using SSDs. See #97968.
ditto
nicktrav
force-pushed
the
nickt.failover-disk-stall
branch
2 times, most recently
from
08b5ef6
to
fce87cd
Compare
There was a problem hiding this comment.
Reviewable status:
Previously, sumeerbhola wrote…
nit: to not use?
Woops. Yes, confusing myself. Fixed.
Previously, sumeerbhola wrote…
nit: something missing/odd in "the used for ..."
Fixed.
pkg/cmd/roachtest/tests/disk_stall.go line 51 at r1 (raw file):
Previously, sumeerbhola wrote…
Confused here too. #99747 says switch to PD.
Done.
pkg/cmd/roachtest/tests/failover.go line 52 at r1 (raw file):
Previously, sumeerbhola wrote…
ditto
Done.
The disk-stalled roachtests were updated in cockroachdb#99747 to use PDs in favor of local SSDs. This change broke the `failover/*/disk-stall` tests, which look for `/dev/sdb` on GCE (the device name used for GCE Persistent Disks), but the tests still create clusters with local SSDs (the roachtest default). Fix cockroachdb#99902. Fix cockroachdb#99926. Fix cockroachdb#99930. Touches cockroachdb#97968. Release note: None.
nicktrav
force-pushed
the
nickt.failover-disk-stall
branch
from
fce87cd
to
545d49a
Compare
|
Rebasing around some CI flakes. |
|
TFTRs! bors r=andrewbaptist |
|
Build succeeded: |
The disk-stalled roachtests were updated in #99747 to use local SSDs. This change broke the
failover/*/disk-stalltests, which look for/dev/sdbon GCE (the used for GCE Persistent Disks), but the tests still create clusters with local SSDs (the roachtest default).Fix #99902.
Fix #99926.
Fix #99930.
Touches #97968.
Release note: None.