Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functions in SushiYieldSource can be external #102

Closed
code423n4 opened this issue Jun 23, 2021 · 1 comment
Closed

Functions in SushiYieldSource can be external #102

code423n4 opened this issue Jun 23, 2021 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

tensors

Vulnerability details

Impact

Changing the functions in SushiYieldSource.sol to external can save gas.

Proof of Concept

https://github.com/pooltogether/sushi-pooltogether/blob/master/contracts/SushiYieldSource.sol

Recommended Mitigation Steps

Change public to external
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Jun 23, 2021
code423n4 added a commit that referenced this issue Jun 23, 2021
@code423n4
tensors issue #102
8c91e8c
@asselstine asselstine added the duplicate This issue or pull request already exists label Jun 24, 2021
@asselstine
Copy link
Collaborator

Duplicate of #107

@asselstine asselstine marked this as a duplicate of #107 Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asselstine @code423n4