Skip to content

Issues: code-423n4/2021-06-pooltogether-findings

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

69 Open 54 Closed
69 Open 54 Closed
Author
Filter by author
Loading
Label
Filter by label
Loading
Use alt + click/return to exclude labels
or ⇧ + click/return for logical OR
Projects
Filter by project
Loading
Milestones
Filter by milestone
Loading
Assignee
Filter by who’s assigned
Sort
Sort by
Newest Oldest Most commented Least commented Recently updated Least recently updated Best match
Most reactions
👍 👎 😄 🎉 😕 ❤️ 🚀 👀

Issues list

Gas optimization on redeemToken of ATokenYieldSource ATokenYieldSource bug Something isn't working G (Gas Optimization) sponsor confirmed
#123 opened Jun 25, 2021 by code423n4
@PierrickGT
1
Gas optimization on _depositToAave ATokenYieldSource bug Something isn't working G (Gas Optimization) sponsor confirmed
#122 opened Jun 25, 2021 by code423n4
@PierrickGT
1
User could lose underlying tokens when redeeming from the IdleYieldSource 3 (High Risk) bug Something isn't working IdleYieldSource sponsor confirmed
#120 opened Jun 25, 2021 by code423n4
@PierrickGT
1
Lack of nonReentrant modifier in yield source contracts 1 (Low Risk) ATokenYieldSource BadgerYieldSource bug Something isn't working IdleYieldSource sponsor confirmed SushiYieldSource
#119 opened Jun 24, 2021 by code423n4
@kamescg
1
onERC721Received not implemented in PrizePool 1 (Low Risk) bug Something isn't working sponsor confirmed
#118 opened Jun 24, 2021 by code423n4
@kamescg
1
Using transferFrom on ERC721 tokens 2 (Med Risk) bug Something isn't working disagree with severity sponsor confirmed
#115 opened Jun 24, 2021 by code423n4
@aodhgan
2
SafeMath not completely used in yield source contracts 2 (Med Risk) bug Something isn't working disagree with severity sponsor confirmed
#114 opened Jun 24, 2021 by code423n4
@aodhgan
2
Return values of ERC20 transfer and transferFrom are unchecked 2 (Med Risk) BadgerYieldSource bug Something isn't working sponsor confirmed SushiYieldSource
#112 opened Jun 24, 2021 by code423n4
@kamescg
2
Unlocked pragma used in multiple contracts 1 (Low Risk) bug Something isn't working sponsor confirmed
#109 opened Jun 24, 2021 by code423n4
@kamescg
1
Declare functions as external to save gas BadgerYieldSource bug Something isn't working G (Gas Optimization) sponsor confirmed SushiYieldSource
#107 opened Jun 24, 2021 by code423n4
@kamescg
1
Use ERC-165 instead of homebrew staticcall-based check bug Something isn't working G (Gas Optimization) sponsor acknowledged
#104 opened Jun 23, 2021 by code423n4
1
IdleYieldSource doesn't use mantissa calculations 3 (High Risk) bug Something isn't working sponsor confirmed
#103 opened Jun 23, 2021 by code423n4
@PierrickGT
1
Gas savings on uninitialized variables. ATokenYieldSource bug Something isn't working G (Gas Optimization) sponsor confirmed
#101 opened Jun 23, 2021 by code423n4
@PierrickGT
1
CreditBurned event emitted even on zero tokens burned bug Something isn't working G (Gas Optimization) sponsor confirmed
#97 opened Jun 23, 2021 by code423n4
@aodhgan
1
Credit accrual is done twice in award bug Something isn't working G (Gas Optimization) sponsor confirmed
#96 opened Jun 23, 2021 by code423n4
@kamescg
1
SushiYieldSource save gas with pre-approval bug Something isn't working G (Gas Optimization) sponsor confirmed SushiYieldSource
#94 opened Jun 23, 2021 by code423n4
@aodhgan
2
ATokenYieldSource save gas with pre-approval ATokenYieldSource bug Something isn't working G (Gas Optimization) IdleYieldSource sponsor confirmed
#93 opened Jun 23, 2021 by code423n4
@aodhgan
3
YieldSourcePrizePool_canAwardExternal does not work 2 (Med Risk) bug Something isn't working sponsor acknowledged
#92 opened Jun 23, 2021 by code423n4
3
withdraw timelock can be circumvented 3 (High Risk) bug Something isn't working sponsor confirmed
#91 opened Jun 23, 2021 by code423n4
@aodhgan
1
YearnV2YieldSource wrong subtraction in withdraw 3 (High Risk) bug Something isn't working sponsor confirmed
#90 opened Jun 23, 2021 by code423n4
@kamescg
1
ATokenYieldSource mixes aTokens and underlying when redeeming 1 (Low Risk) ATokenYieldSource bug Something isn't working sponsor confirmed
#86 opened Jun 23, 2021 by code423n4
@PierrickGT
2
BadgerYieldSource balanceOfToken share calculation seems wrong 3 (High Risk) BadgerYieldSource bug Something isn't working sponsor confirmed
#84 opened Jun 23, 2021 by code423n4
@aodhgan
Missing parameter validation 1 (Low Risk) ATokenYieldSource BadgerYieldSource bug Something isn't working ControlledToken PrizePool sponsor confirmed StakePrizePool SushiYieldSource
#81 opened Jun 23, 2021 by code423n4
8
_depositToAave always returns 0 ATokenYieldSource bug Something isn't working G (Gas Optimization) sponsor confirmed
#80 opened Jun 23, 2021 by code423n4
@PierrickGT
1
Uneven use of events 1 (Low Risk) bug Something isn't working sponsor confirmed
#78 opened Jun 23, 2021 by code423n4
@aodhgan
ProTip! no:milestone will show everything without a milestone.