Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas savings on uninitialized variables. #101

Open
code423n4 opened this issue Jun 23, 2021 · 1 comment
Open

Gas savings on uninitialized variables. #101

code423n4 opened this issue Jun 23, 2021 · 1 comment
Assignees
@PierrickGT
Labels
ATokenYieldSource bug Something isn't working G (Gas Optimization) sponsor confirmed

Comments

@code423n4
Copy link
Contributor

Handle

tensors

Vulnerability details

##Impact
Uninitialized variables initialize to 0 automatically. No need to explicitly initialize it.

##Proof of concept
https://github.com/pooltogether/aave-yield-source/blob/bc65c875f62235b7af55ede92231a495ba091a47/contracts/yield-source/ATokenYieldSource.sol#L141

##Recommended mitigation steps
Replace with: uint256 shares;
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Jun 23, 2021
code423n4 added a commit that referenced this issue Jun 23, 2021
@code423n4
tensors issue #101
c39bb55
@PierrickGT PierrickGT self-assigned this Jun 28, 2021
@PierrickGT PierrickGT mentioned this issue Jun 28, 2021
Merged
@PierrickGT
Copy link
Member

PR: pooltogether/aave-yield-source#16

@PierrickGT PierrickGT mentioned this issue Jul 12, 2021
Merged
@code423n4 code423n4 mentioned this issue Aug 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PierrickGT PierrickGT

Labels
ATokenYieldSource bug Something isn't working G (Gas Optimization) sponsor confirmed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PierrickGT @asselstine @code423n4