fix(contract): gas saving on var initialization #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aodhgan
reviewed
Jun 29, 2021
| @@ -156,7 +156,7 @@ contract ATokenYieldSource is ERC20Upgradeable, IProtocolYieldSource, AssetManag | |||
| /// @param shares Amount of shares | |||
| /// @return Number of tokens | |||
| function _sharesToToken(uint256 shares) internal view returns (uint256) { | |||
| uint256 tokens = 0; | |||
| uint256 tokens; | |||
There was a problem hiding this comment.
How much is the gas saving? Assignment is more readable.
There was a problem hiding this comment.
If we look at supplyTokenTo that calls _tokenToShares, on the main branch it consumes on average 157,718 units of gas and on this branch, it consumes on average 157,718 units of gas, so it doesn't seem to change a thing. 😅
I agree that assignment is more readable.
asselstine
approved these changes
Jul 5, 2021
asselstine
approved these changes
Jul 5, 2021
PierrickGT
force-pushed
the
fixes/tensors-101
branch
from
b911ce9 to
95bd885
Compare
PierrickGT
added a commit
that referenced
this pull request
Jul 6, 2021
fix(contract): gas saving on var initialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: code-423n4/2021-06-pooltogether-findings#101