Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas optimization on redeemToken of ATokenYieldSource #123

Open
code423n4 opened this issue Jun 25, 2021 · 1 comment
Open

Gas optimization on redeemToken of ATokenYieldSource #123

code423n4 opened this issue Jun 25, 2021 · 1 comment
Assignees
@PierrickGT
Labels
ATokenYieldSource bug Something isn't working G (Gas Optimization) sponsor confirmed

Comments

@code423n4
Copy link
Contributor

Handle

shw

Vulnerability details

Impact

At line 213 of ATokenYieldSource, depositToken() can be replaced by _tokenAddress() to save gas since the former is a public function, while the latter is an internal function.

Proof of Concept

Referenced code:
ATokenYieldSource.sol#L213

Recommended Mitigation Steps

Change depositToken() to _tokenAddress().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PierrickGT PierrickGT

Labels
ATokenYieldSource bug Something isn't working G (Gas Optimization) sponsor confirmed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PierrickGT @asselstine @code423n4