Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uneven use of events #78

Open
code423n4 opened this issue Jun 23, 2021 · 0 comments
Open

Uneven use of events #78

code423n4 opened this issue Jun 23, 2021 · 0 comments
Assignees
@aodhgan
Labels
1 (Low Risk) bug Something isn't working sponsor confirmed

Comments

@code423n4
Copy link
Contributor

Handle

JMukesh

Vulnerability details

Impact

To track off-chain data it is necessary to use events

Proof of Concept

In ATokenYieldSource.sol, IdleYieldSource.sol, yearnV2yieldsource : events are emmitted in supplyTokenTo(), redeemToken() sponsor(), but not in BadgerYieldsource.sol and shushiyieldsource.sol

Tools Used

Manual analysis

Recommended Mitigation Steps

use events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aodhgan aodhgan

Labels
1 (Low Risk) bug Something isn't working sponsor confirmed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@asselstine @aodhgan @code423n4