C4 audit mitigations #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use safemath add()
update public functions to external functions
Added supply and redeem events
fix(contract): check constructor addresses
use safemath add()
reduce SLOAD calls in supplyTokenTo
add nonreentrant to supplyTokenTo and redeemToken function
update to support SafeERC20
Audit fix 94 one approve
asselstine
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issues:
nonReentrantmodifier in yield source contracts code-423n4/2021-06-pooltogether-findings#119transferandtransferFromare unchecked code-423n4/2021-06-pooltogether-findings#112externalto save gas code-423n4/2021-06-pooltogether-findings#107