Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing nonReentrant modifiers #16

Closed
code423n4 opened this issue Jun 22, 2021 · 3 comments
Closed

Missing nonReentrant modifiers #16

code423n4 opened this issue Jun 22, 2021 · 3 comments
Labels
1 (Low Risk) bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Handle

pauliax

Vulnerability details

Impact

I expect to see nonReentrant on functions with external calls (e.g. moving tokens). Here is a list (it may not be complete) of functions that do not have this modifier:
Contract SushiYieldSource functions supplyTokenTo, redeemToken. Contract IdleYieldSource function sponsor. Contract BadgerYieldSource functions supplyTokenTo, redeemToken. Contract ATokenYieldSource function sponsor.

Recommended Mitigation Steps

Add nonReentrant modifier to the functions that interact with external actors.

@code423n4 code423n4 added 2 (Med Risk) bug Something isn't working labels Jun 22, 2021
code423n4 added a commit that referenced this issue Jun 22, 2021
@asselstine
Copy link
Collaborator

See #119

@asselstine asselstine added the duplicate This issue or pull request already exists label Jun 24, 2021
@dmvt
Copy link
Collaborator

dmvt commented Jul 31, 2021

dropping this to a level 1 since no threat is actually defined and the other duplicate issues all agree this is a low risk

@dmvt
Copy link
Collaborator

dmvt commented Jul 31, 2021

duplicate of #119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 (Low Risk) bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants