Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare CvxLocker erc20 contract variables as immutable #14

Open
code423n4 opened this issue Sep 7, 2021 · 1 comment
Open

Declare CvxLocker erc20 contract variables as immutable #14

code423n4 opened this issue Sep 7, 2021 · 1 comment
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed

Comments

@code423n4
Copy link
Contributor

Handle

patitonar

Vulnerability details

Impact

Gas optimization to store variables as immutable instead of storage similar to _decimals

Proof of Concept

https://github.com/code-423n4/2021-09-bvecvx/blob/1d64bd58c7a4224cc330cef283561e90ae6a3cf5/veCVX/contracts/locker/CvxLocker.sol#L112-L114

Tools Used

Manual review

Recommended Mitigation Steps

Declare as following:
string private immutable _name;
string private immutable _symbol;
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Sep 7, 2021
code423n4 added a commit that referenced this issue Sep 7, 2021
@code423n4
patitonar issue #14
0dc75b7
@GalloDaSballo
Copy link
Collaborator

Agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GalloDaSballo @code423n4