Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reinvest function should return a uint256 reinvested amount but it returns nothing #16

Closed
code423n4 opened this issue Sep 8, 2021 · 2 comments
Labels
1 (Low Risk) bug Something isn't working duplicate This issue or pull request already exists sponsor confirmed

Comments

@code423n4
Copy link
Contributor

Handle

tabish

Vulnerability details

Impact

Detailed description of the impact of this finding.
reinvesting funds after their lock period is over again in the strategy would not be possible.

Proof of Concept

Provide direct links to all referenced code in GitHub. Add screenshots, logs, or any other relevant proof that illustrates the concept.

link to the function -> https://github.com/code-423n4/2021-09-bvecvx/blob/1d64bd58c7a4224cc330cef283561e90ae6a3cf5/veCVX/contracts/veCVXStrategy.sol#L400

Recommended Mitigation Steps

At the end of the function adding a return toDeposit; would fix this.

@code423n4 code423n4 added 3 (High Risk) bug Something isn't working labels Sep 8, 2021
code423n4 added a commit that referenced this issue Sep 8, 2021
@GalloDaSballo
Copy link
Collaborator

Highly disagree with risk rating, see #18

We should delete the return values

@ghoul-sol
Copy link
Collaborator

duplicate #12 ergo low risk

@ghoul-sol ghoul-sol added 1 (Low Risk) duplicate This issue or pull request already exists and removed 3 (High Risk) labels Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 (Low Risk) bug Something isn't working duplicate This issue or pull request already exists sponsor confirmed
Projects
None yet
Development

No branches or pull requests

3 participants