Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions not returning declared values #18

Open
code423n4 opened this issue Sep 8, 2021 · 1 comment
Open

Functions not returning declared values #18

code423n4 opened this issue Sep 8, 2021 · 1 comment
Labels

Comments

@code423n4
Copy link
Contributor

Handle

pauliax

Vulnerability details

Impact

function withdrawAll in BaseStrategy declares 'returns (uint256 balance)', however, no actual value is returned. function reinvest in MyStrategy declares to return 'uint256 reinvested', however, it also actually does not return anything so they always get assigned a default value of 0.

Recommended Mitigation Steps

Either remove the return declarations or return the intended values. Otherwise, it may confuse other protocols that later may want to integrate with you.

@code423n4 code423n4 added 1 (Low Risk) bug Something isn't working labels Sep 8, 2021
code423n4 added a commit that referenced this issue Sep 8, 2021
@GalloDaSballo
Copy link
Collaborator

We should remove the return values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants