Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code to use calculations at current epoch #8

Open
code423n4 opened this issue Sep 6, 2021 · 0 comments
Open

Refactor code to use calculations at current epoch #8

code423n4 opened this issue Sep 6, 2021 · 0 comments

Comments

@code423n4
Copy link
Contributor

Handle

tensors

Vulnerability details

Impact

Both as a gas optimization and general readability/usability concern: you should make use of the more general functions "atEpoch" to calculate the less general function. For example:

totalSupply() can be rewritten simply as totalSupplyatEpoch( currenctEpoch() ).

If the more general function is already coded, why not use it? It will also save gas.

Proof of Concept

https://github.com/code-423n4/2021-09-bvecvx/blob/1d64bd58c7a4224cc330cef283561e90ae6a3cf5/veCVX/contracts/locker/CvxLocker.sol#L416

Recommended Mitigation Steps

Implement above change.

@code423n4 code423n4 added bug Something isn't working 0 (Non-critical) labels Sep 6, 2021
code423n4 added a commit that referenced this issue Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants