Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas optimization: Unused variable in MochiVault.sol #52

Closed
code423n4 opened this issue Oct 25, 2021 · 1 comment
Closed

Gas optimization: Unused variable in MochiVault.sol #52

code423n4 opened this issue Oct 25, 2021 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

gzeon

Vulnerability details

Impact

The uint256 public liquidated in MochiVault.sol is never used.

Proof of Concept

https://github.com/code-423n4/2021-10-mochi/blob/main/projects/mochi-core/contracts/vault/MochiVault.sol
L37: uint256 public liquidated;

Tools Used

None

Recommended Mitigation Steps

Remove the variable declaration
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Oct 25, 2021
code423n4 added a commit that referenced this issue Oct 25, 2021
@code423n4
gzeon issue #52
5486f51
@r2moon r2moon added the duplicate This issue or pull request already exists label Oct 27, 2021
@r2moon
Copy link
Collaborator

r2moon commented Oct 27, 2021

duplicated with #88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@r2moon @ghoul-sol @code423n4