Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable liquidated in MochiVault is never used #88

Open
code423n4 opened this issue Oct 27, 2021 · 0 comments
Open

Variable liquidated in MochiVault is never used #88

code423n4 opened this issue Oct 27, 2021 · 0 comments
Assignees
@0xleastwood
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Handle

loop

Vulnerability details

The state variable liquidated is initialized in MochiVault, but the contract never writes a value to it, nor is its value read anywhere.

Impact

Takes up a storage slot despite not being used.

Proof of Concept

https://github.com/code-423n4/2021-10-mochi/blob/main/projects/mochi-core/contracts/vault/MochiVault.sol#L37
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Oct 27, 2021
code423n4 added a commit that referenced this issue Oct 27, 2021
@code423n4
loop issue #88
e729ebc
@r2moon r2moon added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Oct 27, 2021
This was referenced Oct 27, 2021
Closed
Closed
Closed
@r2moon r2moon added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Oct 28, 2021
@r2moon r2moon mentioned this issue Oct 28, 2021
Closed
@r2moon r2moon removed the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Oct 29, 2021
@0xleastwood 0xleastwood self-assigned this Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xleastwood 0xleastwood

Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@r2moon @0xleastwood @code423n4