Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MainToken.burn() can be optimized when _value equals zero #59

Closed
code423n4 opened this issue Nov 6, 2021 · 1 comment
Closed

MainToken.burn() can be optimized when _value equals zero #59

code423n4 opened this issue Nov 6, 2021 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

pants

Vulnerability details

The function MainToken.burn() doesn't have to execute these lines of code when _value equals zero:

self.balanceOf[msg.sender] -= _value
self.total_supply -= _value

Impact

There is no reason to execute these lines of code if _value equals zero because they won't affect the system.

Tool Used

Manual code review.

Recommended Mitigation Steps

Execute these lines of code only if _value doesn't equal zero.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 6, 2021
code423n4 added a commit that referenced this issue Nov 6, 2021
@code423n4
pants issue #59
b014ef4
@chickenpie347 chickenpie347 added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Jan 3, 2022
@0xean
Copy link
Collaborator

0xean commented Jan 8, 2022

duplicate of #47

@0xean 0xean closed this as completed Jan 8, 2022
@0xean 0xean added the duplicate This issue or pull request already exists label Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chickenpie347 @0xean @code423n4