Skip to content

Issues: code-423n4/2021-11-streaming-findings

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

118 Open 154 Closed
118 Open 154 Closed
Author
Filter by author
Loading
Label
Filter by label
Loading
Use alt + click/return to exclude labels
or ⇧ + click/return for logical OR
Projects
Filter by project
Loading
Milestones
Filter by milestone
Loading
Assignee
Filter by who’s assigned
Sort
Sort by
Newest Oldest Most commented Least commented Recently updated Least recently updated Best match
Most reactions
👍 👎 😄 🎉 😕 ❤️ 🚀 👀

Issues list

balance(dust) rewardsTokens may be unclaimable after endRewardLock 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
#271 opened Dec 7, 2021 by code423n4
1
Remove unnecessary function can make the code simpler and save some gas bug Something isn't working G (Gas Optimization)
#265 opened Dec 7, 2021 by code423n4
++currStreamId is more gas efficient than currStreamId += 1 bug Something isn't working G (Gas Optimization)
#263 opened Dec 7, 2021 by code423n4
Avoid unnecessary external calls can save gas bug Something isn't working G (Gas Optimization)
#262 opened Dec 7, 2021 by code423n4
1
Code Style: public functions not used by current contract should be external bug Something isn't working G (Gas Optimization)
#260 opened Dec 7, 2021 by code423n4
1
Stream#claimReward() storage writes and reads of ts.rewards can be combined into one bug Something isn't working G (Gas Optimization)
#259 opened Dec 7, 2021 by code423n4
Improper implementation of arbitraryCall() allows protocol gov to steal funds from users' wallets 3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#258 opened Dec 7, 2021 by code423n4
1
Gas Optimization On The 2^256-1 bug Something isn't working G (Gas Optimization)
#255 opened Dec 7, 2021 by code423n4
Incompatibility With Rebasing/Deflationary/Inflationary tokens 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
#252 opened Dec 7, 2021 by code423n4
Redundant code bug Something isn't working G (Gas Optimization)
#250 opened Dec 7, 2021 by code423n4
Inconsistent check of token balance 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#249 opened Dec 7, 2021 by code423n4
10**6 can be changed to 1e6 and save some gas bug Something isn't working G (Gas Optimization)
#248 opened Dec 7, 2021 by code423n4
Incorrect Validation of feePercent 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
#246 opened Dec 7, 2021 by code423n4
1
Avoid unnecessary storage reads can save gas bug Something isn't working G (Gas Optimization)
#245 opened Dec 7, 2021 by code423n4
Insufficient input validation 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working
#243 opened Dec 7, 2021 by code423n4
Wrong calculation of excess depositToken allows stream creator to retrieve depositTokenFlashloanFeeAmount, which may cause fund loss to users 3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#241 opened Dec 7, 2021 by code423n4
1
LockeERC20.sol#toString() Implementation can be simpler and save some gas bug Something isn't working G (Gas Optimization)
#239 opened Dec 7, 2021 by code423n4
Adding unchecked directive can save gas bug Something isn't working G (Gas Optimization)
#238 opened Dec 7, 2021 by code423n4
Constructors should not have visibility 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working
#236 opened Dec 7, 2021 by code423n4
Slot packing increases runtime gas consumption due to masking bug Something isn't working G (Gas Optimization)
#235 opened Dec 7, 2021 by code423n4
Implementations should inherit their interface 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working
#234 opened Dec 7, 2021 by code423n4
Remove unnecessary variables can make the code simpler and save some gas bug Something isn't working G (Gas Optimization)
#233 opened Dec 7, 2021 by code423n4
Cache and read storage variables from the stack can save gas bug Something isn't working G (Gas Optimization)
#232 opened Dec 7, 2021 by code423n4
Use immutable variables can save gas bug Something isn't working G (Gas Optimization)
#231 opened Dec 7, 2021 by code423n4
DOS while dealing with erc20 when value(i.e amount*decimals) is high but less than type(uint112).max 3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#228 opened Dec 7, 2021 by code423n4
1
ProTip! Mix and match filters to narrow down what you’re looking for.