Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementations should inherit their interface #234

Open
code423n4 opened this issue Dec 7, 2021 · 0 comments
Open

Implementations should inherit their interface #234

code423n4 opened this issue Dec 7, 2021 · 0 comments
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working

Comments

@code423n4
Copy link
Contributor

Handle

WatchPug

Vulnerability details

It's a best practice for the contract implementations to inherit their interface definition.

Doing so would improve the contract's clarity, and force the implementation to comply with the defined interface.

Instances include:

https://github.com/code-423n4/2021-11-streaming/blob/56d81204a00fc949d29ddd277169690318b36821/Streaming/src/Locke.sol#L9-L9

contract Governed {

Governed should inherit IGoverned.
@code423n4 code423n4 added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working labels Dec 7, 2021
code423n4 added a commit that referenced this issue Dec 7, 2021
@code423n4
WatchPug issue #234
a1ce23e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@code423n4