Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local variable in fundStream() #127

Open
code423n4 opened this issue Dec 5, 2021 · 0 comments
Open

Use local variable in fundStream() #127

code423n4 opened this issue Dec 5, 2021 · 0 comments
Labels
bug Something isn't working G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

gpersoon

Vulnerability details

Impact

The function fundStream() stores a calculated value in amount.
It saves some gas to use the already present variable "amt"

Proof of Concept

https://github.com/code-423n4/2021-11-streaming/blob/56d81204a00fc949d29ddd277169690318b36821/Streaming/src/Locke.sol#L417-L479

 function fundStream(uint112 amount) public lock {
   ...
        uint112 amt;
  ...
        amount = uint112(newBal - prevBal);   // cheaper to store in amt

Tools Used

Recommended Mitigation Steps

Use amt instead of amount and adapt the rest of the code accordingly.

@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Dec 5, 2021
code423n4 added a commit that referenced this issue Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working G (Gas Optimization)
Projects
None yet
Development

No branches or pull requests

1 participant