We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gpersoon
The function fundStream() stores a calculated value in amount. It saves some gas to use the already present variable "amt"
https://github.com/code-423n4/2021-11-streaming/blob/56d81204a00fc949d29ddd277169690318b36821/Streaming/src/Locke.sol#L417-L479
function fundStream(uint112 amount) public lock { ... uint112 amt; ... amount = uint112(newBal - prevBal); // cheaper to store in amt
Use amt instead of amount and adapt the rest of the code accordingly.
The text was updated successfully, but these errors were encountered:
gpersoon issue #127
3986fd7
No branches or pull requests
Handle
gpersoon
Vulnerability details
Impact
The function fundStream() stores a calculated value in amount.
It saves some gas to use the already present variable "amt"
Proof of Concept
https://github.com/code-423n4/2021-11-streaming/blob/56d81204a00fc949d29ddd277169690318b36821/Streaming/src/Locke.sol#L417-L479
Tools Used
Recommended Mitigation Steps
Use amt instead of amount and adapt the rest of the code accordingly.
The text was updated successfully, but these errors were encountered: