Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Governed's constructor doesn't emit an initial NewGov event #159

Open
code423n4 opened this issue Dec 6, 2021 · 1 comment
Open

Governed's constructor doesn't emit an initial NewGov event #159

code423n4 opened this issue Dec 6, 2021 · 1 comment
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Handle

pants

Vulnerability details

Governed's constructor sets the initial governor but it doesn't emit an initial NewGov event.

Impact

There isn't any event emitted for the initial governor.

Tool Used

Manual code review.

Recommended Mitigation Steps

Emit an initial NewGov event.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Dec 6, 2021
code423n4 added a commit that referenced this issue Dec 6, 2021
@code423n4
pants issue #159
2bbee06
@brockelmore brockelmore added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Dec 6, 2021
@0xean
Copy link
Collaborator

0xean commented Jan 16, 2022 

0 — Non-critical: Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas-optimisations.

Marking as non-critical

@0xean 0xean added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation and removed 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments labels Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@0xean @brockelmore @code423n4