updateStreamInternal does not need msg.sender

[code423n4]

Handle

bitbopper

Vulnerability details

Impact

Uneeded msg.sender creating gas cost in Line:
https://github.com/code-423n4/2021-11-streaming/blob/56d81204a00fc949d29ddd277169690318b36821/Streaming/src/Locke.sol#L203

Proof of Concept

Remove msg.sender from updateStream and updateStreamInternal like so and modify all callers

    modifier updateStream() {
        // save bytecode space by making it a jump instead of inlining at cost of gas
        updateStreamInternal();
        _;
    }

    function updateStreamInternal() internal {

Saved ~8k gas during tests calling stake
in tests with DAPP_BUILD_OPTIMIZE=1 DAPP_BUILD_OPTIMIZE_RUNS=9999999

Tools Used

dapptools

Recommended Mitigation Steps

[0xean]

dupe of #125