Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inaccurate comment in recoverTokens #213

Open
code423n4 opened this issue Dec 7, 2021 · 0 comments
Open

Inaccurate comment in recoverTokens #213

code423n4 opened this issue Dec 7, 2021 · 0 comments
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

cmichel

Vulnerability details

The recoverTokens function's comment states that the excess deposit tokens are balance - depositTokenAmount:

*      1. if its deposit token:
*          - DepositLock is fully done
*          - There are excess deposit tokens (balance - depositTokenAmount)

But it is balance - (depositTokenAmount - redeemedDepositTokens) where (depositTokenAmount - redeemedDepositTokens) is the outstanding redeemable amount.

Impact

The code is correct.

Recommended Mitigation Steps

Fix the comment.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Dec 7, 2021
code423n4 added a commit that referenced this issue Dec 7, 2021
@code423n4
cmichel issue #213
7e971ec
@brockelmore brockelmore added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brockelmore @code423n4