Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas: unstreamed not needed #216

Open
code423n4 opened this issue Dec 7, 2021 · 0 comments
Open

Gas: unstreamed not needed #216

code423n4 opened this issue Dec 7, 2021 · 0 comments
Labels
bug Something isn't working G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

cmichel

Vulnerability details

The unstreamed storage variable is redundant and the system can already track everything without this storage variable.
Note that this variable is never read and only written to.
(The system essentially tracks deposit_balance * deposit_duration for each user and pays out the fair share compared to the total cumulative balance times duration once at the end.)

Removing this variable saves a lot of gas as every updateStreamInternal call has to do fewer computations.

@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Dec 7, 2021
code423n4 added a commit that referenced this issue Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working G (Gas Optimization)
Projects
None yet
Development

No branches or pull requests

1 participant