Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas: Check _feePercent instead #217

Open
code423n4 opened this issue Dec 7, 2021 · 0 comments
Open

Gas: Check _feePercent instead #217

code423n4 opened this issue Dec 7, 2021 · 0 comments
Labels
bug Something isn't working G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

cmichel

Vulnerability details

The Stream.constructor performs a check on a storage variable instead of the parameter: require(feePercent < 10000, "fee"). This will do an unnecessary sload operation. Consider doing the check on _feePercent instead.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Dec 7, 2021
code423n4 added a commit that referenced this issue Dec 7, 2021
@code423n4
cmichel issue #217
1f02bc0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@code423n4