Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused modifier/function argument "who" #43

Closed
code423n4 opened this issue Dec 1, 2021 · 1 comment
Closed

Remove unused modifier/function argument "who" #43

code423n4 opened this issue Dec 1, 2021 · 1 comment
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working duplicate This issue or pull request already exists sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

GiveMeTestEther

Vulnerability details

Impact

The modifier "updateStreams" (L197) takes an argument "address who" and passes it to the function "updateStreamInternal" (L203). But this argument is never used in "updateStreamInternal" function.
To save gas by passing arguments that are not used, remove function parameter "address who" from the modifier and the function declaration.

Proof of Concept

https://github.com/code-423n4/2021-11-streaming/blob/56d81204a00fc949d29ddd277169690318b36821/Streaming/src/Locke.sol#L197

https://github.com/code-423n4/2021-11-streaming/blob/56d81204a00fc949d29ddd277169690318b36821/Streaming/src/Locke.sol#L203

Tools Used

Recommended Mitigation Steps

  • remove function parameter "address who" from the modifier and the function declaration.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Dec 1, 2021
code423n4 added a commit that referenced this issue Dec 1, 2021
@code423n4
GiveMeTestEther issue #43
3a9ea99
@brockelmore brockelmore added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Dec 2, 2021
@0xean
Copy link
Collaborator

0xean commented Jan 16, 2022

dupe of #125

@0xean 0xean added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments and removed G (Gas Optimization) labels Jan 16, 2022
@0xean 0xean mentioned this issue Jan 17, 2022
Closed
@0xean 0xean added the duplicate This issue or pull request already exists label Jan 18, 2022
@0xean 0xean closed this as completed Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working duplicate This issue or pull request already exists sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@0xean @brockelmore @code423n4