Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lack of inputs validation #53

Closed
code423n4 opened this issue Dec 2, 2021 · 1 comment
Closed

Lack of inputs validation #53

code423n4 opened this issue Dec 2, 2021 · 1 comment
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Handle

0x1f8b

Vulnerability details

Impact

Lack of inputs during deployment could produce a re-deploy with human errors.

Proof of Concept

The unique variable validated was feePercent, but all the address must be checked to be != address(0) and _startTime + _streamDuration must be less than the current block.

Source reference:
https://github.com/code-423n4/2021-11-streaming/blob/56d81204a00fc949d29ddd277169690318b36821/Streaming/src/Locke.sol#L264-L274

Tools Used

Manual review

Recommended Mitigation Steps

Validate the input params, the address must be != address(0)
@code423n4 code423n4 added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working labels Dec 2, 2021
code423n4 added a commit that referenced this issue Dec 2, 2021
@code423n4
0x1f8b issue #53
108414e
@0xean
Copy link
Collaborator

0xean commented Jan 16, 2022

dupe of #68

@0xean 0xean added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments duplicate This issue or pull request already exists and removed 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation labels Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@0xean @code423n4 @CloudEllie