Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal functions to private #7

Open
code423n4 opened this issue Nov 30, 2021 · 0 comments
Open

Internal functions to private #7

code423n4 opened this issue Nov 30, 2021 · 0 comments
Labels
bug Something isn't working G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

robee

Vulnerability details

The following functions could be set private to save gas and improve code quality:
The function assertGtDecimal in test.sol could be set internal
The function checkEq0 in test.sol could be set internal
The function assertGeDecimal in test.sol could be set internal
The function assertEqDecimal in test.sol could be set internal
The function assertGt in test.sol could be set internal
The function assertEq in test.sol could be set internal
The function assertLt in test.sol could be set internal
The function assertLe in test.sol could be set internal
The function assertLeDecimal in test.sol could be set internal
The function assertEq0 in test.sol could be set internal
The function assertLtDecimal in test.sol could be set internal
The function assertTrue in test.sol could be set internal
The function assertGe in test.sol could be set internal
The function assertEq32 in test.sol could be set internal
The function fail in test.sol could be set internal
The function isAuthorized in Auth.sol could be set internal
The function verifySafeTransfer in SafeTransferLib.t.sol could be set internal
The function forceApprove in SafeTransferLib.t.sol could be set internal
The function verifySafeTransferFrom in SafeTransferLib.t.sol could be set internal
The function verifySafeApprove in SafeTransferLib.t.sol could be set internal
The function forceTrust in Trust.t.sol could be set internal
The function forceTrust in TrustAuthority.t.sol could be set internal
The function addTargetContract in DSInvariantTest.sol could be set internal
The function startMeasuringGas in DSTestPlus.sol could be set internal
The function stopMeasuringGas in DSTestPlus.sol could be set internal
The function assertBytesEq in DSTestPlus.sol could be set internal
The function assertUint64Eq in DSTestPlus.sol could be set internal
The function assertUint96Eq in DSTestPlus.sol could be set internal
The function assertUint32Eq in DSTestPlus.sol could be set internal
The function fail in DSTestPlus.sol could be set internal
The function assertUint128Eq in DSTestPlus.sol could be set internal
The function assertFalse in DSTestPlus.sol could be set internal
The function _burn in ERC20.sol could be set internal
The function _mint in ERC20.sol could be set internal
The function fromLast20Bytes in Bytes32AddressLib.sol could be set internal
The function fillLast12Bytes in Bytes32AddressLib.sol could be set internal
The function deploy in CREATE3.sol could be set internal
The function fmul in FixedPointMathLib.sol could be set internal
The function sqrt in FixedPointMathLib.sol could be set internal
The function max in FixedPointMathLib.sol could be set internal
The function fpow in FixedPointMathLib.sol could be set internal
The function min in FixedPointMathLib.sol could be set internal
The function fdiv in FixedPointMathLib.sol could be set internal
The function safeCastTo64 in SafeCastLib.sol could be set internal
The function safeCastTo224 in SafeCastLib.sol could be set internal
The function safeCastTo128 in SafeCastLib.sol could be set internal
The function read in SSTORE2.sol could be set internal
The function write in SSTORE2.sol could be set internal
The function toString in LockeERC20.sol could be set internal
The function _burn in LockeERC20.sol could be set internal
The function _mint in LockeERC20.sol could be set internal

@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 30, 2021
code423n4 added a commit that referenced this issue Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working G (Gas Optimization)
Projects
None yet
Development

No branches or pull requests

1 participant