Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constructor Does Not Check for Zero Addresses #75

Closed
code423n4 opened this issue Dec 3, 2021 · 1 comment
Closed

Constructor Does Not Check for Zero Addresses #75

code423n4 opened this issue Dec 3, 2021 · 1 comment
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Handle

Meta0xNull

Vulnerability details

Impact

A wrong user input or wallets defaulting to the zero addresses for a missing input can lead to the contract needing to redeploy or wasted gas.

Proof of Concept

https://github.com/code-423n4/2021-11-streaming/blob/main/Streaming/src/Locke.sol#L17-L19

Tools Used

Manual Review

Recommended Mitigation Steps

requires Addresses is not zero.

require(_governor != address(0), "Address Can't Be Zero")
require(_emergency_governor != address(0), "Address Can't Be Zero")
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Dec 3, 2021
code423n4 added a commit that referenced this issue Dec 3, 2021
@code423n4
Meta0xNull issue #75
c0e9c7c
@0xean
Copy link
Collaborator

0xean commented Jan 16, 2022

dupe of #68

@0xean 0xean closed this as completed Jan 16, 2022
@0xean 0xean added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments duplicate This issue or pull request already exists and removed G (Gas Optimization) labels Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0xean @code423n4