Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inaccuate comment about claimFees() #94

Open
code423n4 opened this issue Dec 4, 2021 · 0 comments
Open

Inaccuate comment about claimFees() #94

code423n4 opened this issue Dec 4, 2021 · 0 comments
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working

Comments

@code423n4
Copy link
Contributor

Handle

GeekyLumberjack

Vulnerability details

Impact

This may lead someone to believe the function works differently than it does.

Proof of Concept

//@audit inaccurate comment, this function will claim fees in rewards and in deposit tokens /** * @dev Allows the governance contract of the factory to select a destination * and transfer fees (in rewardTokens) to that address totaling the total fee amount */

Recommended Mitigation Steps

Update comment to include a note about deposit fees being claimed in this function
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Dec 4, 2021
code423n4 added a commit that referenced this issue Dec 4, 2021
@code423n4
GeekyLumberjack issue #94
3ab2ed2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@code423n4