Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use one require instead of several #96

Open
code423n4 opened this issue Dec 4, 2021 · 1 comment
Open

Use one require instead of several #96

code423n4 opened this issue Dec 4, 2021 · 1 comment
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Handle

Jujic

Vulnerability details

Impact

You can use in one require several checks to save gas.

Proof of Concept

https://github.com/code-423n4/2021-11-streaming/blob/56d81204a00fc949d29ddd277169690318b36821/Streaming/src/Locke.sol#L585-L592

Tools Used

Recommended Mitigation Steps

require (isSale && !claimedDepositTokens && msg.sender == streamCreator && block.timestamp >= endStream, "claim error");
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Dec 4, 2021
code423n4 added a commit that referenced this issue Dec 4, 2021
@code423n4
Jujic issue #96
d51cb74
@brockelmore
Copy link
Collaborator

Not a tradeoff i want to make in terms of code readability

@brockelmore brockelmore added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brockelmore @code423n4