Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to temporarily save old values when updating settings #99

Open
code423n4 opened this issue Dec 4, 2021 · 0 comments
Open

No need to temporarily save old values when updating settings #99

code423n4 opened this issue Dec 4, 2021 · 0 comments
Labels
bug Something isn't working G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

kenzo

Vulnerability details

In updateStreamParams and updateFeeParams, the old values are being saved (probably in order to log them) before being updated.
This is unnecessary.

Impact

Small amount of gas can be saved. (Although maybe it was done this way for code clarity..?)

Proof of Concept

In updateFeeParams
https://github.com/code-423n4/2021-11-streaming/blob/main/Streaming/src/Locke.sol#L850:#L855:

function updateFeeParams(GovernableFeeParams memory newFeeParams) public governed {
        require(newFeeParams.feePercent <= MAX_FEE_PERCENT, "fee");
        GovernableFeeParams memory old = feeParams;
        feeParams = newFeeParams;
        emit FeeParametersUpdated(old, newFeeParams);
    }

The code can be changed to:

function updateFeeParams(GovernableFeeParams memory newFeeParams) public governed {
        require(newFeeParams.feePercent <= MAX_FEE_PERCENT, "fee");
        emit FeeParametersUpdated(feeParams, newFeeParams);
        feeParams = newFeeParams;
}

Same thing can be done in updateStreamParams.
https://github.com/code-423n4/2021-11-streaming/blob/main/Streaming/src/Locke.sol#L841:#L848

@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Dec 4, 2021
code423n4 added a commit that referenced this issue Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working G (Gas Optimization)
Projects
None yet
Development

No branches or pull requests

1 participant