We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kenzo
In updateStreamParams and updateFeeParams, the old values are being saved (probably in order to log them) before being updated. This is unnecessary.
updateStreamParams
updateFeeParams
Small amount of gas can be saved. (Although maybe it was done this way for code clarity..?)
In updateFeeParams https://github.com/code-423n4/2021-11-streaming/blob/main/Streaming/src/Locke.sol#L850:#L855:
function updateFeeParams(GovernableFeeParams memory newFeeParams) public governed { require(newFeeParams.feePercent <= MAX_FEE_PERCENT, "fee"); GovernableFeeParams memory old = feeParams; feeParams = newFeeParams; emit FeeParametersUpdated(old, newFeeParams); }
The code can be changed to:
function updateFeeParams(GovernableFeeParams memory newFeeParams) public governed { require(newFeeParams.feePercent <= MAX_FEE_PERCENT, "fee"); emit FeeParametersUpdated(feeParams, newFeeParams); feeParams = newFeeParams; }
Same thing can be done in updateStreamParams. https://github.com/code-423n4/2021-11-streaming/blob/main/Streaming/src/Locke.sol#L841:#L848
The text was updated successfully, but these errors were encountered:
kenzo issue #99
56c8b38
No branches or pull requests
Handle
kenzo
Vulnerability details
In
updateStreamParams
andupdateFeeParams
, the old values are being saved (probably in order to log them) before being updated.This is unnecessary.
Impact
Small amount of gas can be saved. (Although maybe it was done this way for code clarity..?)
Proof of Concept
In
updateFeeParams
https://github.com/code-423n4/2021-11-streaming/blob/main/Streaming/src/Locke.sol#L850:#L855:
The code can be changed to:
Same thing can be done in
updateStreamParams
.https://github.com/code-423n4/2021-11-streaming/blob/main/Streaming/src/Locke.sol#L841:#L848
The text was updated successfully, but these errors were encountered: