Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open TODOs #128

Closed
code423n4 opened this issue Dec 18, 2021 · 2 comments
Closed

Open TODOs #128

code423n4 opened this issue Dec 18, 2021 · 2 comments
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Handle

defsec

Vulnerability details

Impact

Open TODOs can point to architecture or programming issues that still need to be resolved.

Proof of Concept

  1. Navigate to the following contracts.
https://github.com/code-423n4/2021-12-amun/blob/cf890dedf2e43ec787e8e5df65726316fda134a1/contracts/basket/contracts/interfaces/IRebalanceManagerV2.sol#L10

https://github.com/code-423n4/2021-12-amun/blob/cf890dedf2e43ec787e8e5df65726316fda134a1/contracts/basket/contracts/interfaces/IRebalanceManager.sol#L12

https://github.com/code-423n4/2021-12-amun/blob/cf890dedf2e43ec787e8e5df65726316fda134a1/contracts/basket/contracts/interfaces/IPangolinRebalanceManager.sol#L13

Tools Used

None

Recommended Mitigation Steps

Consider resolving the TODOs before deploying.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Dec 18, 2021
code423n4 added a commit that referenced this issue Dec 18, 2021
@code423n4
defsec issue #128
741eb2b
@0xleastwood
Copy link
Collaborator

No direct security implications. Marking as non-critical.

@0xleastwood 0xleastwood added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation and removed 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments labels Jan 23, 2022
@0xleastwood
Copy link
Collaborator

Duplicate of #267

@0xleastwood 0xleastwood marked this as a duplicate of #267 Jan 23, 2022
@0xleastwood 0xleastwood added the duplicate This issue or pull request already exists label Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0xleastwood @code423n4