Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open TODOs #267

Open
code423n4 opened this issue Dec 19, 2021 · 1 comment
Open

Open TODOs #267

code423n4 opened this issue Dec 19, 2021 · 1 comment
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working

Comments

@code423n4
Copy link
Contributor

Handle

Dravee

Vulnerability details

Impact

Open TODOs can point to architecture or programming issues that still need to be resolved.

Proof of Concept

The TODOs are here:
https://github.com/code-423n4/2021-12-amun/blob/main/contracts/basket/contracts/interfaces/IRebalanceManagerV2.sol#L10
https://github.com/code-423n4/2021-12-amun/blob/main/contracts/basket/contracts/interfaces/IRebalanceManager.sol#L12
https://github.com/code-423n4/2021-12-amun/blob/main/contracts/basket/contracts/interfaces/IRebalanceManager.sol#L18
https://github.com/code-423n4/2021-12-amun/blob/main/contracts/basket/contracts/interfaces/IPangolinRebalanceManager.sol#L13

Tools Used

VS Code

Recommended Mitigation Steps

Consider resolving the TODOs before deploying.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Dec 19, 2021
code423n4 added a commit that referenced this issue Dec 19, 2021
@code423n4
Dravee issue #267
c0bffc9
@0xleastwood
Copy link
Collaborator

Not an issue, marking as non-critical.

@0xleastwood 0xleastwood added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation and removed 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments labels Jan 22, 2022
This was referenced Jan 23, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0xleastwood @code423n4