Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODOs #261

Closed
code423n4 opened this issue Dec 19, 2021 · 1 comment
Closed

TODOs #261

code423n4 opened this issue Dec 19, 2021 · 1 comment
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Handle

pauliax

Vulnerability details

Impact

There are TODOs left in the code:

  uint256 minReturn; //Minimum quantity to buy //todo change to price for safty

While this does not cause any direct issue, it indicates a bad smell and uncertainty and makes it harder to audit. Consider fixing TODOs or removing distracting comments.
@code423n4 code423n4 added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working labels Dec 19, 2021
code423n4 added a commit that referenced this issue Dec 19, 2021
@code423n4
pauliax issue #261
f9f9f9f
@0xleastwood
Copy link
Collaborator

Duplicate of #267

@0xleastwood 0xleastwood marked this as a duplicate of #267 Jan 23, 2022
@0xleastwood 0xleastwood added the duplicate This issue or pull request already exists label Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0xleastwood @code423n4