Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #67

Open
code423n4 opened this issue May 1, 2022 · 2 comments
Open

Gas Optimizations #67

code423n4 opened this issue May 1, 2022 · 2 comments
Assignees
@PierrickGT
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Make 3 indexed variables to save gas
https://github.com/pooltogether/aave-v3-yield-source/blob/0f52c5ff27e7c2ef1b32fe2fb12ac16b1bba5e75/contracts/AaveV3YieldSource.sol#L41
https://github.com/pooltogether/aave-v3-yield-source/blob/0f52c5ff27e7c2ef1b32fe2fb12ac16b1bba5e75/contracts/AaveV3YieldSource.sol#L58
https://github.com/pooltogether/aave-v3-yield-source/blob/0f52c5ff27e7c2ef1b32fe2fb12ac16b1bba5e75/contracts/AaveV3YieldSource.sol#L66
https://github.com/pooltogether/aave-v3-yield-source/blob/0f52c5ff27e7c2ef1b32fe2fb12ac16b1bba5e75/contracts/AaveV3YieldSource.sol#L75
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels May 1, 2022
code423n4 added a commit that referenced this issue May 1, 2022
@code423n4
simon135 issue #67
63967b6
@PierrickGT PierrickGT self-assigned this May 3, 2022
@PierrickGT
Copy link
Member

I think it's worthwhile to index the owner address in AaveV3YieldSourceInitialized event but as a rule of thumb, it's best to only index addresses that may be relevant if we need to build a subgraph.

@PierrickGT PierrickGT mentioned this issue May 3, 2022
Merged
@PierrickGT
Copy link
Member

PR: pooltogether/aave-v3-yield-source#11

@PierrickGT PierrickGT added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PierrickGT PierrickGT

Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PierrickGT @code423n4