Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(contract): index owner in initialize event #11

Merged
merged 1 commit into from
Jun 2, 2022
Merged

fix(contract): index owner in initialize event #11

merged 1 commit into from
Jun 2, 2022

Conversation

PierrickGT
Copy link
Contributor

@PierrickGT PierrickGT requested a review from asselstine May 3, 2022 23:14
@PierrickGT PierrickGT temporarily deployed to fork May 3, 2022 23:14 Inactive
@PierrickGT PierrickGT mentioned this pull request May 3, 2022
Open
asselstine
asselstine approved these changes Jun 2, 2022
View reviewed changes
contracts/AaveV3YieldSource.sol
@@ -43,7 +43,7 @@ contract AaveV3YieldSource is ERC20, IYieldSource, Manageable, ReentrancyGuard {
string name,
string symbol,
uint8 decimals,
address owner
address indexed owner
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm...seems silly to emit this as there is already an OwnershipTransferred event.

no big deal

Base automatically changed from fix/35 to fix/4 June 2, 2022 21:38
@PierrickGT PierrickGT merged commit 77a6dc3 into fix/4 Jun 2, 2022
@PierrickGT PierrickGT deleted the fix/67 branch June 2, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asselstine asselstine asselstine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PierrickGT @asselstine