Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #174

Open
c4-submissions opened this issue Nov 3, 2023 · 6 comments
Open

QA Report #174

c4-submissions opened this issue Nov 3, 2023 · 6 comments
Labels
bug Something isn't working edited-by-warden grade-b Q-28 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality

Comments

@c4-submissions
Copy link
Contributor

See the markdown file with the details of this report here.

@c4-submissions c4-submissions added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Nov 3, 2023
c4-submissions added a commit that referenced this issue Nov 3, 2023
c4-submissions added a commit that referenced this issue Nov 3, 2023
c4-bot-7 added a commit that referenced this issue Nov 4, 2023
c4-bot-10 added a commit that referenced this issue Nov 6, 2023
@141345
Copy link

141345 commented Nov 25, 2023

174 0x3b
l r nc
2 0 0

L 1 l
L 2 d dup of #962
L 3 i
L 4 l
L 5 i
L 6 d dup of #688

@c4-pre-sort
Copy link

141345 marked the issue as sufficient quality report

@c4-pre-sort c4-pre-sort added the sufficient quality report This report is of sufficient quality label Nov 25, 2023
@alex-ppg
Copy link

alex-ppg commented Dec 8, 2023

QA Judgment

The Warden's QA report has been graded B based on a score of 20 combined with a manual review per the relevant QA guideline document located here.

The Warden's submission's score was assessed based on the following accepted findings:

Low-Risk

@c4-judge
Copy link

c4-judge commented Dec 8, 2023

alex-ppg marked the issue as grade-b

@0x3b33
Copy link

0x3b33 commented Dec 9, 2023

Hey, L-06 is a duplicate of 1148, and I believe its severity should not be 'L' but marked as 'M' and marked as dupe. The same should be done with L-02, as it also points to the main root cause and is explained good enough, although shortly. The only issue is that I have misjudged the severity of those findings, I didn't submit them as medium in order to not spam the contest with inflated findings. Generally it is recommended that hard to qualify finding should be submitted as LOWs and if it's a MED the judge will raise it to it's appropriate severity.

@alex-ppg
Copy link

alex-ppg commented Dec 9, 2023

Hey @0x3b33, thanks for contributing! Submission #1148 ended up being nullified in the PJQA process.

Concerning #1275, I do not deem this submission to be of sufficient quality to be eligible for a portion of its rewards. #1275 and its duplicates have a detailed PoC, elaborate on what the impact is, how it should be corrected, etc. In the interest of fairness, I cannot provide this QA submission a reward as its comparative quality is very low and it would incentivize giant QA reports to be submitted that detail all issues and leave the burden of upgrading to the judges which is unfair from a contest's perspective.

@C4-Staff C4-Staff added the Q-28 label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working edited-by-warden grade-b Q-28 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality
Projects
None yet
Development

No branches or pull requests

8 participants