Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine our Repeat/Loop-feature ( Include popout player & Exclude ads?) #1504

Open
1 of 7 tasks
Tracked by #1445
ImprovedTube opened this issue Nov 25, 2022 · 1 comment
Open
1 of 7 tasks
Tracked by #1445
Labels
bounty Will pass on donations (Optional) - (OR: Requester will pay personally. Only if stated!) Bug Bug or required update after YouTube changes Completion / Revision Rethink, complete, improve, tweak our feature or structure. List of tasks Efficient to have a List for this (sub-)project. (Each task might be worth an extra thread.) 🧩Plan ready Solution or some specification noted; To-Do; steps for implementation (+raw brainstorming too maybe)

Comments

@ImprovedTube
Copy link
Member

ImprovedTube commented Nov 25, 2022

  • dont repeat preroll ads (bug / needs an update) this only needs to apply to always-on (while manually clicking repeat is fine to apply to ads)

    } else if (!/ad-showing/.test(ImprovedTube.elements.player.className)) {
    if (this.storage.player_always_repeat === true) {
    setTimeout(function () {
    ImprovedTube.elements.video.setAttribute('loop', '');

  • when the popup player is opened while repeating,
    then the following can be prepended to the popup URL: &loop=1&playlist= VIDEO-ID

  • remember looping (once or unlimited) for each video

  • allow repeating by category only like music or education (implemented at our speed-watching feature only yet. but many of our features might consider such data in future)

  • allow sticky-on with rightclick (faster than finding always repeat button in our list of features) compare <video> Player buttons to be added</video> #1445

  • separate the always repeat switch from the buttons (in our function & GUI), so that it works alone. ImprovedTube.alwaysRepeat = function () { if(this.storage.player_always_repeat === true)

  • icon/s options

    • Current (repeat this one song): M7 7h10v3l4-4-4-4v3H5v6h2V7zm10 10H7v-3l-4 4 4 4v-3h12v-6h-2v4zm-4-2V9h-1l-2 1v1h1.5v4H13z
    • Without "1" M7 7h10v3l4-4-4-4v3H5v6h2V7zm10 10H7v-3l-4 4 4 4v-3h12v-6h-2v4z
    • With "unlimited"-sign ∞ : M7 7h10v3l4-4-4-4v3H5v6h2zm10 10H7v-3l-4 4 4 4v-3h12v-6h-2v4zm-5.998-6.283C8.272 8.994 6.453 12.769 9.365 13.612 10.592 13.828 6.116 12.577 9.172 10.579 9.846 10.266 13.938 11.638 9.678 13.563 11.411 13.876 13.505 9.352 15.677 10.476 18.119 12.179 15.135 15.814 12.036 11.831 14.968 14.063 15.469 13.396 15.928 12.728 16.928 9.225 13.342 10.518 12.084 11.855z
@ImprovedTube ImprovedTube added the Completion / Revision Rethink, complete, improve, tweak our feature or structure. label Nov 25, 2022
@ImprovedTube ImprovedTube self-assigned this Nov 25, 2022
@ImprovedTube ImprovedTube removed their assignment Nov 25, 2022
@ImprovedTube ImprovedTube changed the title Refine or Repeat/Loop-feature ( Include popout player & Exclude ads?) Refine our Repeat/Loop-feature ( Include popout player & Exclude ads?) Dec 2, 2022
@mrangjunboons2017
Copy link

a typo?

@ImprovedTube ImprovedTube added the bounty Will pass on donations (Optional) - (OR: Requester will pay personally. Only if stated!) label Dec 27, 2023
ImprovedTube added a commit that referenced this issue Feb 8, 2024
ImprovedTube added a commit that referenced this issue Feb 8, 2024
ImprovedTube added a commit that referenced this issue Feb 8, 2024
ImprovedTube added a commit that referenced this issue Feb 8, 2024
@ImprovedTube ImprovedTube added List of tasks Efficient to have a List for this (sub-)project. (Each task might be worth an extra thread.) 🧩Plan ready Solution or some specification noted; To-Do; steps for implementation (+raw brainstorming too maybe) Bug Bug or required update after YouTube changes YouTube changed and removed YouTube changed labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty Will pass on donations (Optional) - (OR: Requester will pay personally. Only if stated!) Bug Bug or required update after YouTube changes Completion / Revision Rethink, complete, improve, tweak our feature or structure. List of tasks Efficient to have a List for this (sub-)project. (Each task might be worth an extra thread.) 🧩Plan ready Solution or some specification noted; To-Do; steps for implementation (+raw brainstorming too maybe)
Projects
Status: No status
Development

No branches or pull requests

2 participants