Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename autoplay to reflect its real function #2110

Merged
merged 14 commits into from
Apr 2, 2024
Merged

Rename autoplay to reflect its real function #2110

merged 14 commits into from
Apr 2, 2024

Conversation

raszpl
Copy link
Contributor

@raszpl raszpl commented Mar 22, 2024

core.js rename ignore_autoplay_off to user_interacted
player.js rename ignore_autoplay_off to user_interacted
player.js rename autoplay to autoplayDisable
player.js rename autoplay to autoplay_disable, player_autoplay to pla…
player.js rename player_autoplay to player_autoplay_disable
functions.js rename ignore_autoplay_off to user_interacted
functions.js rename autoplay to autoplayDisable
shortcuts.js rename player_autoplay to player_autoplay_disable
playlist.js rename player_autoplay to player_autoplay_disable
general.js rename player_autoplay to player_autoplay_disable
/en/messages.json rename autoplay to autoplay_disable

Requires to rename rest of locales and fix translations!

This was referenced Mar 22, 2024
@ImprovedTube
Copy link
Member

  • When features are renamed or inverted in our code:
    # IMPORTING OLD SETTINGS

    chrome.storage.local.get('hideSubscribe', function (result) {if (result.hideSubscribe === true){ chrome.storage.local.set({subscribe: 'hidden'}); }});

@raszpl
Copy link
Contributor Author

raszpl commented Mar 25, 2024

linked code is broken :) runs every update:
Lets say user had hideSubscribe = true, extension updated and subscribe = 'hidden' was set, then user switched subscribe to 'normal', then another update came and users subscribe 'normal' was again overwritten by 'hidden'.
limit_page_width correctly calls chrome.storage.local.remove(['limit_page_width']
fix #2121

@ImprovedTube
Copy link
Member

didnt remove hideSubscribe just in case of rolling back

@ImprovedTube ImprovedTube merged commit c31aaa8 into code-charity:master Apr 2, 2024
@raszpl raszpl deleted the rename-autoplay branch April 3, 2024 12:31
@raszpl
Copy link
Contributor Author

raszpl commented Apr 3, 2024

missed one rename #2156
also autoplayDisable could use some more readability #2157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants