Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing automatic code reviews #1

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Testing automatic code reviews #1

wants to merge 8 commits into from

Conversation

code-schreiber
Copy link
Owner

No description provided.

@ReviewMeBot
Copy link

ReviewMeBot commented Jun 7, 2019

2 Warnings
⚠️ Please provide a PR description
⚠️ This PR is quite a big one! Try splitting this into separate tasks next time 🙂
1 Message
📖 Thank you for your work @code-schreiber 🎉 You might find a few suggestions from me below 😉

Detekt found issues

warning (1)

File Line Reason
app/src/main/java/com/toolslab/reviewme/MainActivity.kt 11 This comment contains text that has been defined as forbidden in detekt.

Generated by 🚫 Danger

package="com.toolslab.reviewme">

<application>
<application
Copy link

@ReviewMeBot ReviewMeBot Jun 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Should explicitly set android:icon, there is no default

}

Copy link

@ReviewMeBot ReviewMeBot Jun 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Unexpected blank line(s) before “}”

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants