Testing automatic code reviews

.travis.yml

@@ -21,8 +21,9 @@ android:
 
 script:
   - ./gradlew build
-  - ./gradlew :app:ktlintCheck
-  - ./gradlew :app:lint
+  - ./gradlew detekt
+  - ./gradlew ktlintCheck
+  - ./gradlew lint
   - bundle install
   - bundle exec danger
 

Dangerfile

@@ -1,13 +1,12 @@
+# Docs and setup at https://danger.systems
+
 # Sometimes it's a README fix, or something like that - which isn't relevant for
 # including in a project's CHANGELOG for example
 declared_trivial = github.pr_title.include? "#trivial"
 
 # Make it more obvious that a PR is a work in progress and shouldn't be merged yet
 warn("PR is classed as Work in Progress") if github.pr_title.include? "[WIP]"
 
-# Warn when there is a big PR
-warn("Big PR") if git.lines_of_code > 500
-
 # Give a warning if the PR description is empty
 warn("Please provide a PR description") if github.pr_body.length < 5
 
@@ -23,5 +22,11 @@ checkstyle_format.report "app/build/reports/ktlint/ktlintMainSourceSetCheck.xml"
 # AndroidLint
 android_lint.report_file = "app/build/reports/lint-results.xml"
 android_lint.skip_gradle_task = true
-android_lint.severity = "Error"
 android_lint.lint(inline_mode: true)
+# For projects with tons of warnings, you may want to filter only new/modified files
+# android_lint.filtering = true
+
+kotlin_detekt.report_file = "app/build/reports/detekt/detekt.xml"
+kotlin_detekt.skip_gradle_task = true
+# kotlin_detekt.filtering = true
+kotlin_detekt.detekt

Gemfile

@@ -7,3 +7,4 @@ git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
 gem 'danger'
 gem 'danger-checkstyle_format'
 gem 'danger-android_lint'
+gem 'danger-kotlin_detekt'

Gemfile.lock

@@ -32,6 +32,8 @@ GEM
     danger-checkstyle_format (0.1.1)
       danger-plugin-api (~> 1.0)
       ox (~> 2.0)
+    danger-kotlin_detekt (0.0.3)
+      danger-plugin-api (~> 1.0)
     danger-plugin-api (1.0.0)
       danger (> 2.0)
     faraday (0.15.4)
@@ -70,6 +72,7 @@ DEPENDENCIES
   danger
   danger-android_lint
   danger-checkstyle_format
+  danger-kotlin_detekt
 
 BUNDLED WITH
    1.17.1

app/build.gradle

@@ -2,6 +2,7 @@ apply plugin: 'com.android.application'
 apply plugin: 'kotlin-android'
 apply plugin: 'kotlin-android-extensions'
 apply plugin: "org.jlleitschuh.gradle.ktlint"
+apply plugin: "io.gitlab.arturbosch.detekt"
 
 import org.jlleitschuh.gradle.ktlint.reporter.ReporterType
 
@@ -22,8 +23,13 @@ android {
     }
 }
 
+detekt {
+    config = files("default-detekt-config.yml")
+}
+
 ktlint {
     android = true
+    ignoreFailures = true
     reporters = [ReporterType.PLAIN, ReporterType.CHECKSTYLE]
 }