-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4 Migration Guide #1248
Comments
Okay in the end the issue wasn't that I needed to change anything, but that Dependabot PRs didn't have access to CODECOV_TOKEN. Still, a migration guide would have let me get to the conclusion that it wasn't a param change or something faster. |
Hi @bmulholland could you kindly explain what needs to be changed (some repo config, some GH actions yml file?) to make the dependabot PRs have access to the env var? |
@Bibo-Joshi, you will need to add the The URL will be something like https://github.com/{{ org }}/{{ repo }}/settings/secrets/dependabot |
^ would be very useful to add/link to in https://github.com/codecov/codecov-action?tab=readme-ov-file#dependabot |
…ov/codecov-action-4 Bump codecov/codecov-action from 3 to 4
I have CODECOV_TOKEN in the org level yet I get
in the upload stage of my action https://github.com/fortio/fortio/actions/runs/7788613704/job/21238404141?pr=886#step:5:26 Not sure how to fix it tbh |
nvm I needed fortio/fortio@8eef6d7 @@ -23,3 +23,5 @@ jobs:
run: make coverage
- name: Upload coverage to Codecov
uses: codecov/codecov-action@e0b68c6749509c5f83f984dd99a76a1c1a231044 # pin@v3
+ with:
+ token: ${{ secrets.CODECOV_TOKEN }} |
@ldemailly can you open a separate issue with this and a link if possible? Can help try to debug what happened on that upload |
Same here, fails with:
I've added a token. |
same here. I get the following error after updating to v4 in GitHub actions (redacted):
If it's worth noticing, I see the error |
@mwestphal @pritamrungta would you be able to provide more information here? A link to CI would be great, but if not, maybe the Codecov step in your CI? Want to try to get this figured out |
Hi @thomasrockhu-codecov Another note in continuation to the last message: When running codecov for |
@pritamrungta what happens if you run it with
|
Previous step:
Updated step:
And I still get the following error:
If it helps, this is the successful attempt using codecov/codecov-action@v3 (Previous step):
|
FWIW, I'm also having a problem migrating from v3 to v4: ''' The full log is here: Here is my changes to our workflow file: I removed the root_dir: setting since - according to the docs it shouldn't be necessary for git-based repo. In any case when I had "root_dir: ." it failed with the same traceback. thanks |
I'm getting a 500 error - not sure how to debug it? jest-community/eslint-plugin-jest#1494 |
Same issue as @mwestphal : @thomasrockhu-codecov Let me know if you need anything else.. |
Hi 👋🏽
@kgiusti @mwestphal @tvdijen |
@chouetz I don't have a git repo available at all at this stage. I've generated coverage files several steps before and I'm basically only trying to upload the build-directory.. This used to work fine in v3 |
It seems that v4 is having some teething problems - coverage is no longer being uploaded due to the lack of a token, and it seems like at least some people are getting 500s even when they do provide a token (codecov/codecov-action#1248). Let's start by downgrading to a known working version, and go from there. Relates to #784 Before: <img width="1009" alt="image" src="https://github.com/google/osv-scanner/assets/3151613/24e6556f-0c94-4c4a-9269-cd59188f303f"> After: <img width="1334" alt="image" src="https://github.com/google/osv-scanner/assets/3151613/3e5bd689-0daf-410e-814c-62facf3ef50c">
I managed to fix the root_dir issue by setting the
|
Hi all, thanks for bearing with us as we rolled out This thread has a few too many issues and is hard for us to track and manage. If you are experiencing issues with |
|
v4 has breaking changes, but it's not clear what I need to actually do to fix them. There should be easy instructions on how to migrate actions. Especially just the basic case...
I only use two arguments to the action, and it's not uploading coverage now. That's a pretty basic use case but it's not at all clear what I need to do to fix it.
The text was updated successfully, but these errors were encountered: