[v4] Can't determine root folder

[bmulholland]

I upgraded to v4 action and now get "Can't determine root folder." I can't figure out how to fix it.

This is for e2e tests, where we check out the code under test to a subdirectory, "frontend". This worked fine, without any options on v3. How do I fix it for v4?

Line that is thrown is here: https://github.com/codecov/codecov-cli/blob/main/codecov_cli/helpers/versioning_systems.py#L109

As far as I can tell, this doesn't use any passed in CLI option? So there's no way to configure it for the subdir.

[bmulholland]

A migration guide would be really helpful here...

[webknjaz]

@bmulholland might be related to #1252?

[bmulholland]

Only in the sense that It’s the same error, and may have the same fix. For that issue, you can workaround it by checking the files out using git. For mine, it IS checked out, just in a subdirectory.

[thomasrockhu-codecov]

codecov/feedback#263

[thomasrockhu-codecov]

I'm going to close this out as a dupe of codecov/feedback#263. The error messages are different, but the root is the same.

[thomasrockhu-codecov]

@bmulholland @webknjaz

[Bo98]

codecov/feedback#263 describes a permissions issue with containers while this issue happens outside of containers too and I think(?) describes root_dir not working, which is relevant if the git repo isn't in GITHUB_WORKSPACE.

It seems the behaviour has changed so v3-like root_dir is now working-directory. I'm not entirely sure what v4 root_dir does, but it seems different than documented and might be worth renaming.

Changing to working-directory is OK for me. However there's a problem with working-directory: it does not work with the create-commit and create-report stages - only the upload stage: https://github.com/codecov/codecov-action/blob/v4.0.1/src/buildExec.ts. It needs to be passed in all stages because all of them issue git commands.

[bmulholland]

@thomasrockhu-codecov sorry, why do you think it's related? We don't run in a container, and I didn't say anything about one?

[bmulholland]

That issue also mentions git-service but that feels wrong. I'll try working-directory...

[bmulholland]

Okay it's working-directory AND the git thing, I think.

Instead of using the workaround I'll wait until that's actually fixed. Where can I subscribe to know when it's ready?

[thomasrockhu-codecov]

@bmulholland I've seen you a bit everywhere, and I'm not sure what your status is. Can you confirm if you're stilling running into a problem, and what specifically the issue is?

[bmulholland]

@thomasrockhu-codecov yes, I'm still running into a problem. My situation is really simple: we checkout the code to a subdirectory on github actions, and that's enough to not work on the upgrade.

Firstly, the coverage upload is failing but returning success. Secondly, there's no documentation on how to upgrade. Thirdly, I needed to set working-directory to the subdirectory. Fourth, even when I do that, the upload fails, saying things like Commit creating failed: ["Service not found: none"] and ci service found: github-actions and Upload failed: ["Commit SHA not found"]

[bmulholland]

Note that @mwestphal is also having this problem: #1248 (comment)

FYI, the upshot so far is: to fix the "Can't determine root folder," you need to set the working-directory argument. However, this then runs into a secondary issue, codecov/feedback#263, which has a workaround but no real fix. The claim is that the workaround shouldn't be necessary when using actions/checkout but that's not my experience.

[mwestphal]

Thanks Ill try that.

[Bo98]

f62c5ee isn't in a release tag yet so you'll need to point to that commit manually to test out working-directory properly

[bmulholland]

Well, okay then, can we re-open this until it's available? Or how can we otherwise get notified when it's out?

[felixfontein]

FYI, the upshot so far is: to fix the "Can't determine root folder," you need to set the working-directory argument.

Yeah, this is the hint that actually makes sense. We were using directory before, which worked fine with v3.

[thomasrockhu-codecov]

working-directory is now in 4.1.0