-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v4] Can't determine root folder #1258
Comments
A migration guide would be really helpful here... |
@bmulholland might be related to #1252? |
Only in the sense that It’s the same error, and may have the same fix. For that issue, you can workaround it by checking the files out using git. For mine, it IS checked out, just in a subdirectory. |
I'm going to close this out as a dupe of codecov/feedback#263. The error messages are different, but the root is the same. |
codecov/feedback#263 describes a permissions issue with containers while this issue happens outside of containers too and I think(?) describes It seems the behaviour has changed so v3-like Changing to |
@thomasrockhu-codecov sorry, why do you think it's related? We don't run in a container, and I didn't say anything about one? |
That issue also mentions git-service but that feels wrong. I'll try working-directory... |
Okay it's working-directory AND the git thing, I think. Instead of using the workaround I'll wait until that's actually fixed. Where can I subscribe to know when it's ready? |
@bmulholland I've seen you a bit everywhere, and I'm not sure what your status is. Can you confirm if you're stilling running into a problem, and what specifically the issue is? |
@thomasrockhu-codecov yes, I'm still running into a problem. My situation is really simple: we checkout the code to a subdirectory on github actions, and that's enough to not work on the upgrade. Firstly, the coverage upload is failing but returning success. Secondly, there's no documentation on how to upgrade. Thirdly, I needed to set working-directory to the subdirectory. Fourth, even when I do that, the upload fails, saying things like |
Note that @mwestphal is also having this problem: #1248 (comment) FYI, the upshot so far is: to fix the "Can't determine root folder," you need to set the |
Thanks Ill try that. |
f62c5ee isn't in a release tag yet so you'll need to point to that commit manually to test out |
Well, okay then, can we re-open this until it's available? Or how can we otherwise get notified when it's out? |
|
* Bump codecov/codecov-action from 3 to 4 Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3...v4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Need working-directory instead of directory. Ref: codecov/codecov-action#1258 (comment) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Felix Fontein <felix@fontein.de>
* Bump codecov/codecov-action from 3 to 4 Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3...v4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Need working-directory instead of directory. Ref: codecov/codecov-action#1258 (comment) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Felix Fontein <felix@fontein.de>
* Bump codecov/codecov-action from 3 to 4 Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3...v4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Need working-directory instead of directory. Ref: codecov/codecov-action#1258 (comment) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Felix Fontein <felix@fontein.de>
* Bump codecov/codecov-action from 3 to 4 Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3...v4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Need working-directory instead of directory. Ref: codecov/codecov-action#1258 (comment) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Felix Fontein <felix@fontein.de>
* Bump codecov/codecov-action from 3 to 4 Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3...v4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Need working-directory instead of directory. Ref: codecov/codecov-action#1258 (comment) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Felix Fontein <felix@fontein.de>
I upgraded to v4 action and now get "Can't determine root folder." I can't figure out how to fix it.
This is for e2e tests, where we check out the code under test to a subdirectory, "frontend". This worked fine, without any options on v3. How do I fix it for v4?
Line that is thrown is here: https://github.com/codecov/codecov-cli/blob/main/codecov_cli/helpers/versioning_systems.py#L109
As far as I can tell, this doesn't use any passed in CLI option? So there's no way to configure it for the subdir.
The text was updated successfully, but these errors were encountered: