-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v4] Commit creating failed: ["Service not found: none"] #263
Comments
I'm seeing the same thing in https://github.com/jonhoo/flurry/actions/runs/7765831951/job/21180957330, and I suspect the problem is related to the job running in a container. I have upgraded a bunch of other repos to v4 without issue (beyond having to set the |
Not sure but it seems that the target repository must be checked out to the root directory. Otherwise codecov-action@v4 fails with "Service not found: none" error. https://github.com/codecov/codecov-action/issues/1253
I have the issue too, and also only for jobs running in a container :) |
I'm having this problem too. |
Currenlty working on a fix |
Hi all, I've figured out the root cause, but I don't have a forever solution. For now, a workaround is to add
before running Codecov. I didn't expect this to be a problem since the I'm looking to add this into the CLI, but I'm not yet 100% we will want this behavior there. |
The root cause of this error is that all
The repo This call SHOULD be made by the checkout step (see the previous comment issues tagged) and this log. but we notice that this isn't happening. A possible solution would be to have the CLI make this call ( |
The |
Workaround worked. Thanks! |
Hi, |
@drazisil-codecov sorry, I combined a few issues into this one here, because the root cause is still this #263 (comment) |
FYI I'm getting this for runs that don't use a container, but checks out code to a subdirectory instead. Specifically, uses |
In case this helps anyone, it seems In my workflow, the coverage get generated in a "Build & Test" job, which is then handed off to a separate "Coverage Analysis" job as an artifact (using That setup had worked fine for Many thanks to this comment for the inspiration. |
@dfed it looks like the latest run you made is working, is that accurate? @jonhoo thanks for sharing your repo, I have tested a fix out on a fork and it looks promising. The fix should be shipped sometime next week. If you would like to see if this fix will work for you, please use this version of the action
|
@thomasrockhu-codecov I am unblocked because I used the I just put up a PR to test your new codecov sha and we'll know if it worked in ~6 minutes |
@dfed ah! I totally missed that in the config, you're right |
@thomasrockhu-codecov good news! |
Hi, I don't know if it was supposed to fix it, but I can report that version 4.0.2 does not fix the issue for me - see skaut/shared-drive-mover#1518 |
@thomasrockhu-codecov can you take a look at this PR codecov/codecov-cli#376? I thought that it might resolve the issue and it has not been reviewed for 3 weeks already. |
@marekdedic |
Got it, thanks for taking a look. I am ok as long as the issue is fixed. I did notice that in the PR you mentioning that the issue will fix it for containers. In my case, I am not using any containers and I am hoping that your PR will fix both issues. |
@kdarkhan that issue is on my list, thanks for bringing it up. Any more information you can bring to it would be helpful when tackling this week. |
Ok, a fix has been made in |
Confirmed this is working for me with |
Confirming v4.1.0 fixes the issue for me as well, thanks! :) |
@kdarkhan can you take a look and see if |
The issue with the "service not found" is fixed but I am still facing an error with the upload file not being found. I think this is specific to running the coverage report in specific subdirectory, so let me move that conversation into codecov/codecov-action#1287 |
@kdarkhan I had to add with: -> working_directory: "path" to codecov's action |
Closing this out as the original issue has been resolved. |
I'm trying to migrate to v4 and I've encountered two errors on an
ubuntu-latest
runner.First: same error message as codecov/codecov-action#1252, which I fixed by adding a Setup Python step to ensure that 3.10 was installed.
Second:
Commit creating failed: ["Service not found: none"]
I haven't yet found a workaround for this second issue.
For what it's worth, my macOS runner is succeeding with v4.
[@thomasrockhu-codecov edit]
The root cause of this error is that all
git
calls made by the CLI here are failing. The error message isThe repo
example-python
will of course be different for each repo.This call SHOULD be made by the checkout step (see the previous comment issues tagged) and this log.
![image](https://private-user-images.githubusercontent.com/88201630/302472393-27c03d31-423b-48bf-9d19-ef8130de3a49.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ0MTA1OTIsIm5iZiI6MTcyNDQxMDI5MiwicGF0aCI6Ii84ODIwMTYzMC8zMDI0NzIzOTMtMjdjMDNkMzEtNDIzYi00OGJmLTlkMTktZWY4MTMwZGUzYTQ5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIzVDEwNTEzMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ0ODgzZWQ1YjdmYzg5MjU2ODZhMTQzMmQ1NTJmMGE2ZjdjMzAzMTNmZTZlMzJlMjVlNDYxZjkxNDg3ZjM1ZWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.3FLI32DUDCD7LXCNy8bK0gX_h48K2zzaREq1LO9JP5M)
but we notice that this isn't happening.
A possible solution would be to have the CLI make this call (
git config --global --add safe.directory <working_dir>
), but not sure if that's the solution we want.The text was updated successfully, but these errors were encountered: